Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optional types for MeshTransmissionMaterialType #1780

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

la55u
Copy link
Contributor

@la55u la55u commented Jan 15, 2024

Why

I changed distortionScale and temporalDistortion to be optional on the MeshTransmissionMaterialType because they have defaults as mentioned in the docs comments.

What

Checklist

  • Documentation updated (example)
  • Storybook entry added (example)
  • Ready to be merged

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2024 10:46am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6929201:

Sandbox Source
headless-shape-npf5v6 Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@la55u la55u changed the title Fix MeshTransmissionMaterialType fix: optional types for MeshTransmissionMaterialType Jan 15, 2024
@drcmda drcmda merged commit d1a5f7a into pmndrs:master Jan 30, 2024
4 checks passed
Copy link

🎉 This PR is included in version 9.97.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@la55u la55u deleted the patch-2 branch January 31, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants