feat: update three to r151 #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
🎉 This PR is included in version 9.100.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Methuselah96
added a commit
to Methuselah96/drei
that referenced
this pull request
Mar 9, 2024
Another reference to TextureEncoding snuck in through pmndrs#1850. Since now there's more than one, I created a shared typed.
1 task
drcmda
pushed a commit
that referenced
this pull request
Mar 12, 2024
Another reference to TextureEncoding snuck in through #1850. Since now there's more than one, I created a shared typed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I was looking to improving some types but when I installed the project, it said that
three-mesh-bvh@0.7.0is expecting three >= r151What
I noticed that we are still using r149 for development so I updated it to r151 to meet the minimum requirements of
three-mesh-bvhand corrected the few type issues that came up.Checklist