-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since release 9.99.3 my app breaks if I use suspend while rendering a Text component #1886
Comments
ping @CodyJasonBennett sorry to bother you but this issue is preventing me from upgrading both Is there anything I can do to ease debugging this? It should be fairly easy to reproduce the issue by the linked repository. many thanks 🙇🏼 |
This seems like a deeper issue since React allows multiple promises to suspend within a tree -- otherwise it's impossible to not have waterfalls. I'm reverting that patch though as it's no longer needed. |
🎉 This issue has been resolved in version 9.105.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
many thanks for the quick action @CodyJasonBennett 🙏🏼 |
I can also confirm that the fix works - I updated all relevant packages and everything is working as expected |
three
version: 0.160.0@react-three/fiber
version: 8.15.19@react-three/drei
version: 9.99.3node
version: v20.11.0npm
(oryarn
) version: 10.4.0Problem description:
I have an application that uses
suspend
to lazy load a Recast navmesh.Ever since #1841 was merged - or since release
9.99.3
- I cannot have both a<Text />
component, and also usesuspend
elsewhere, even if in an unrelated component. I have tested to wrap my component(s) in<Suspense/>
in different configurations, but with no effect.Relevant code:
Here is simple reproduction: https://github.com/GGAlanSmithee/react-three-dre-text-bug-reproduction
If you look in the
Scene.tsx
file, there are two code blocks in the jsx that you can uncomment to replicate the issue:Instructions
https://github.com/GGAlanSmithee/react-three-dre-text-bug-reproduction
npm i
npm run dev
The text was updated successfully, but these errors were encountered: