Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow StatsGl style customization via prop and forward ref #2030

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

davcri
Copy link
Contributor

@davcri davcri commented Jul 15, 2024

Why

To simplify StatsGl customization which is currently limited.

What

  1. Exported stats.dom via forward ref
  2. Add id and clearStatsGlStyle props

Checklist

I'll update doc and storybook if changes make sense to be merged. Just let me know.

  • Documentation updated (example)
  • Storybook entry added (example)
  • Ready to be merged

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 2:27pm

Copy link

codesandbox-ci bot commented Jul 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@CodyJasonBennett
Copy link
Member

Are you still working on this?

@davcri
Copy link
Contributor Author

davcri commented Jul 24, 2024

Hi @CodyJasonBennett currently done for what I wanted to do which is to add the StatsGL widget to a custom div element

image

Let me know if I need to create a storybook example for this

@CodyJasonBennett CodyJasonBennett changed the title fix: allow StatsGl style customization via prop and forward ref feat: allow StatsGl style customization via prop and forward ref Sep 22, 2024
Copy link

vercel bot commented Sep 22, 2024

@CodyJasonBennett is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

@CodyJasonBennett CodyJasonBennett merged commit 5cce7d0 into pmndrs:master Sep 22, 2024
3 of 4 checks passed
Copy link

🎉 This PR is included in version 9.113.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants