feat: add clear and preload function to useEnvironment #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AaronClaes is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
🎉 This PR is included in version 9.112.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
abernier
reviewed
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2076
Why
Pull request for the following feature: #2076
What
I added a
clearandpreloadfunction foruseEnvironmentbased onuseLoader.I also restructured parts of the hook to be able to reuse them in the
clearandpreloadfunctions, to prevent duplicate code.The only limitation is that gainmaps cannot be preloaded, but this is stated in the updated documentation.
The reason is that their loader requires the renderer to be set, which is not possible. An error will be thrown when attempting to preload a gainmap.
Checklist