fix: Makes Loader go from 0 to 100 instead of 0 to 1 #280
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/drei/h0ad1l1zo |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cdb216b:
|
|
It's funny, I saw this all last week, and told myself "I must fix it" and I never did, what would we do without you? |
|
Thankfully I'm here, to fix the stuff that REALLY matters, like this U_U |
|
Do you think we still need Travis? I'm not actually clear on what it does. |
|
@joshuaellis @gsimone @drcmda This one makes me remember of one bug. When we want to load something new, the loader assets will stack because we use the same instance of LoadingManager. So it means for example it will do 0 -> 1 on the first load. Then 0.5 -> 1 etc.... because this one is never reset : So I guess we should use a fresh instance of LoadingManager instead of DefaultLoadingManager like this : |
|
Are you talking about if there are multiple suspense wrappers in an app? |
|
Makes sense to use multiple Loaders, since this component is intended to "hide" the whole app - so it implies that it's only ever used one at a time |
|
Can we write that in the docs then, please? I know it's a bit trivial, I do remember someone having an issue with that, and I did have a similar scenario myself and was confused about what was going on till I really thought about it 👀 |
|
🎉 This PR is included in version 3.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Come on.