fix: remove target prop type in controls where it isn't applicable #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
After looking at various controls during (#285) I noticed they all have
target
specified in their types. Only three actually need it/can use it on the Three.js side:OrbitControls
,TrackballControls
andMapControls
(which is OrbitControls underneath).What
Removes prop types where they are not applicable/are misplaced. For PointerLockControls, this fix is handled in #285.
Checklist