Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove target prop type in controls where it isn't applicable #286

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

jure
Copy link
Contributor

@jure jure commented Feb 3, 2021

Why

After looking at various controls during (#285) I noticed they all have target specified in their types. Only three actually need it/can use it on the Three.js side: OrbitControls, TrackballControls and MapControls (which is OrbitControls underneath).

What

Removes prop types where they are not applicable/are misplaced. For PointerLockControls, this fix is handled in #285.

Checklist

  • Ready to be merged

@vercel
Copy link

vercel bot commented Feb 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/drei/r3tj098k9
✅ Preview: https://drei-git-fork-jure-fixextrapropfields.pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 3, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5a657e7:

Sandbox Source
inspiring-mendel-2yfw6 Configuration
drei reflector Configuration

@joshuaellis joshuaellis changed the base branch from master to beta February 3, 2021 13:06
@joshuaellis
Copy link
Member

There's a fix on beta for ESM modules that I need to check this evening, so I'm gonna merge them into beta first. I have no doubt that you're code works though 🦖

@github-actions
Copy link

github-actions bot commented Feb 3, 2021

🎉 This PR is included in version 3.2.3-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released on @beta released in beta for review label Feb 3, 2021
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @beta released in beta for review released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants