-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reflector): adds debug prop and improves depth blurring #288
Conversation
…ending on the depth factor
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/drei/3wkbskygs |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3f0a3c5:
|
… material + adds depthbuffer in convolution material shader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we tackle issue #277 in this PR, please? Unless you've already done it and I'm being silly.
Gonna merge when Marco is ready with the demo ✌️ |
I'll leave this for you to merge. |
New reflector: https://codesandbox.io/s/frosty-reflector-23xxw I have also added various combinations in the storybook |
🎉 This PR is included in version 3.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Why
the previous reflector added the depth texture to the shader but the fading of the reflection in function of the depth was not perceptible
Closes #293