Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reflector): adds debug prop and improves depth blurring #288

Merged
merged 12 commits into from
Feb 10, 2021

Conversation

emmelleppi
Copy link
Member

@emmelleppi emmelleppi commented Feb 4, 2021

Why

the previous reflector added the depth texture to the shader but the fading of the reflection in function of the depth was not perceptible

  • Documentation updated
  • Storybook entry added
  • Ready to be merged

Closes #293

@vercel
Copy link

vercel bot commented Feb 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/drei/3wkbskygs
✅ Preview: https://drei-git-reflector-v3.pmndrs.vercel.app

@emmelleppi emmelleppi marked this pull request as draft February 4, 2021 17:41
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 4, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3f0a3c5:

Sandbox Source
vigilant-greider-f4fo7 Configuration
drei reflector Configuration
arc-x-pmndrs-colors Configuration
lucid-kapitsa-i5w04 Issue #293

… material + adds depthbuffer in convolution material shader
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we tackle issue #277 in this PR, please? Unless you've already done it and I'm being silly.

@emmelleppi
Copy link
Member Author

Can we tackle issue #277 in this PR, please? Unless you've already done it and I'm being silly.
@gsimone is the example I put in the storybook okay or were you thinking of something different (adding tweaks, multiple stories, etc.)?

@gsimone
Copy link
Member

gsimone commented Feb 10, 2021

Gonna merge when Marco is ready with the demo ✌️

@joshuaellis
Copy link
Member

Gonna merge when Marco is ready with the demo

I'll leave this for you to merge.

@emmelleppi
Copy link
Member Author

Gonna merge when Marco is ready with the demo ✌️

New reflector: https://codesandbox.io/s/frosty-reflector-23xxw
Old reflector: https://codesandbox.io/s/frosty-reflector-old-version-uox4t

I have also added various combinations in the storybook

@gsimone gsimone changed the title feat(reflector): adds debug prop and improves the blur-base ratio dep… feat(reflector): adds debug prop and improves depth blurring Feb 10, 2021
@gsimone gsimone merged commit 0350c35 into master Feb 10, 2021
@gsimone gsimone deleted the reflector-v3 branch February 10, 2021 17:36
@github-actions
Copy link

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflector tweaks
3 participants