Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Controls to receive active camera from props #320

Closed
gsimone opened this issue Mar 4, 2021 · 3 comments
Closed

Change Controls to receive active camera from props #320

gsimone opened this issue Mar 4, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers released

Comments

@gsimone
Copy link
Member

gsimone commented Mar 4, 2021

This would allow orbit controls in non-default camera scenarios, such as multiple fbos

ooor.mov
@gsimone gsimone added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Mar 4, 2021
@joshuaellis
Copy link
Member

To clarify, this is because the current impl, uses the default camera?

@gsimone
Copy link
Member Author

gsimone commented Mar 5, 2021

yeah, I tested the change it just works ™ with few changes https://codesandbox.io/s/r3f-multi-view-mdnhl?file=/src/OrbitControls.js

This should be done for all controls (including Transform, IIRC)

@joshuaellis joshuaellis added the good first issue Good for newcomers label Mar 5, 2021
@joshuaellis
Copy link
Member

Closed by #321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsimone @joshuaellis