Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix line #325

Merged
merged 1 commit into from
Mar 11, 2021
Merged

fix line #325

merged 1 commit into from
Mar 11, 2021

Conversation

drcmda
Copy link
Member

@drcmda drcmda commented Mar 11, 2021

line component didnt get updated with dash, it will simply flip to non-dashed when points change. useeffect is also wrong, needs to be a layouteffect or else it flickers.

@vercel
Copy link

vercel bot commented Mar 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/drei/FC3S6thTng3Z9upce7mPzrrEksAn
✅ Preview: https://drei-git-fix-line-pmndrs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b03f49a:

Sandbox Source
late-darkness-8wjkm Configuration
drei reflector Configuration
arc-x-pmndrs-colors Configuration

@joshuaellis joshuaellis merged commit 31aa77f into master Mar 11, 2021
@joshuaellis joshuaellis deleted the fix-line branch March 11, 2021 08:25
@github-actions
Copy link

🎉 This PR is included in version 3.10.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 4.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released on @beta released in beta for review label Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @beta released in beta for review released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants