New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linewidth prop in Line component should be camel case #97

Closed

gsimone opened this issue Aug 24, 2020 · 1 comment · Fixed by #98

Assignees

Member

gsimone commented Aug 24, 2020

Can we make an alias to avoid a breaking change?

gsimone assigned giulioz

Member

giulioz commented Aug 24, 2020

It's lowercase since it injects into LineMaterial properties directly.
https://github.com/mrdoob/three.js/blob/3a993b4180f5230e1f34a21b30caaff9eb8ac44f/examples/jsm/lines/LineMaterial.d.ts#L28

Unfortunately it's the only one lowercase.

giulioz mentioned this issue

Renamed linewidth to lineWidth #98

Merged

giulioz closed this as completed in #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment