Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Configuration Check for InFactory #130

Closed
pasetti opened this issue Jul 24, 2018 · 1 comment
Closed

Incorrect Configuration Check for InFactory #130

pasetti opened this issue Jul 24, 2018 · 1 comment
Assignees
@pasetti

Comments

@pasetti
Copy link
Contributor

pasetti commented Jul 24, 2018

In CrFwAux.c, I should make the following change:

CrFwBool_t CrFwAuxInFactoryInRepConfigCheck() {
CrFwCmdRepKindIndex_t i;

if ((CR_FW_INREP_NKINDS >0) && (CR_FW_INFACTORY_MAX_NOF_INREP < 1))
	return 0;

if (CR_FW_INREP_NKINDS < 1)
	return 1;
   . . .

I need the change to cover the case of an application which does not receive any incoming reports.
@pasetti pasetti self-assigned this Jul 24, 2018
@pasetti
Copy link
Contributor Author

pasetti commented Jul 25, 2018

Fix has been made for all command/report configuration checks.

@pasetti pasetti closed this as completed Jul 25, 2018
pasetti added a commit that referenced this issue Jul 25, 2018
@pasetti
Fixed configuration check as per Issue #130
1e100fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pasetti pasetti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pasetti