Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design handling of messages to non-existent nodes in VirtualNet #375

Open
vkomenda opened this issue Jan 3, 2019 · 1 comment
Open

Design handling of messages to non-existent nodes in VirtualNet #375

vkomenda opened this issue Jan 3, 2019 · 1 comment

Comments

@vkomenda
Copy link
Contributor

vkomenda commented Jan 3, 2019

#372 added a filter that clears messages addressed to removed nodes. There has been a discussion about possible future evolution of this filtering mechanism:

  1. Keep it and make sure it works when multiple nodes are removed and readded, Remove a random subset of validators in net_dynamic_hb #374.

  2. Drop the NodeDisappearedInCrank error and the filter altogether.

  3. Add an additional flag that turns the filter on and off during the test.

Each of those variants has its drawbacks:

  1. Was criticised for adding no value at the cost of some complexity.

  2. Would probably reduce the informative error message to a less informative expect message.

  3. The removed node IDs are stored in a set. Why having an additional flag? The set is more expressive since the empty set means ON and the set containing all node IDs means OFF.

Some design might be necessary to fit this issue into a broader picture and make the changes worthwhile.

@afck
Copy link
Collaborator

afck commented Jan 3, 2019

Realistically, if a node restarts, I imagine some of the messages will be lost and others may reach it after restart. It would be great if we could simulate that, i.e. effectively only drop a random subset of the node's messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants