You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#372 added a filter that clears messages addressed to removed nodes. There has been a discussion about possible future evolution of this filtering mechanism:
Drop the NodeDisappearedInCrank error and the filter altogether.
Add an additional flag that turns the filter on and off during the test.
Each of those variants has its drawbacks:
Was criticised for adding no value at the cost of some complexity.
Would probably reduce the informative error message to a less informative expect message.
The removed node IDs are stored in a set. Why having an additional flag? The set is more expressive since the empty set means ON and the set containing all node IDs means OFF.
Some design might be necessary to fit this issue into a broader picture and make the changes worthwhile.
The text was updated successfully, but these errors were encountered:
Realistically, if a node restarts, I imagine some of the messages will be lost and others may reach it after restart. It would be great if we could simulate that, i.e. effectively only drop a random subset of the node's messages.
#372 added a filter that clears messages addressed to removed nodes. There has been a discussion about possible future evolution of this filtering mechanism:
Keep it and make sure it works when multiple nodes are removed and readded, Remove a random subset of validators in net_dynamic_hb #374.
Drop the
NodeDisappearedInCrank
error and the filter altogether.Add an additional flag that turns the filter on and off during the test.
Each of those variants has its drawbacks:
Was criticised for adding no value at the cost of some complexity.
Would probably reduce the informative error message to a less informative
expect
message.The removed node IDs are stored in a set. Why having an additional flag? The set is more expressive since the empty set means ON and the set containing all node IDs means OFF.
Some design might be necessary to fit this issue into a broader picture and make the changes worthwhile.
The text was updated successfully, but these errors were encountered: