Added modifiers row up down #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
reviewed
Aug 5, 2021
Co-authored-by: Pokey Rule <pokey.rule@gmail.com>
pokey
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
take row 5chuck up 2clear down 4I have after testing determined that this modifier has huge impact on compile performance. The culprit is the capture
<number>combining two of those with the primitive target just blows up the compilation time to over two seconds. I made a simplified version which only uses one<number_small>but that alone adds over 300ms. I'm afraid that we are pushing the capabilities of talon's grammar in terms of performance.