Added spoken form to API #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
reviewed
Aug 1, 2021
| @@ -68,8 +77,10 @@ def cursorless_multiple_target_command( | |||
| ): | |||
| """Execute multi-target cursorless command""" | |||
| args = list(filter(lambda x: x is not NotSet, [arg1, arg2, arg3])) | |||
| spoken_form = " ".join(last_phrase["phrase"]) | |||
There was a problem hiding this comment.
Just to check, if I say "disk take air", this won't pick up the initial "disk" right?
There was a problem hiding this comment.
It will. So we are going to have some discipline when we do the test cases.
There was a problem hiding this comment.
Hmm. Ok I'm gonna approve this one just so you're not blocked on adding tests to your other PRs but not sure I'm in love with passing through the whole command to every cursorless command. Let's discuss later
There was a problem hiding this comment.
Yes I think we could improve this. Just unsure of the best solution right now.
pokey
approved these changes
Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.