Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECHDEBT] GenericParam & ActorSpecificParam with one semantic name #206

Closed
5 tasks
andrewnguyen22 opened this issue Sep 12, 2022 · 1 comment
Closed
5 tasks

[TECHDEBT] GenericParam & ActorSpecificParam with one semantic name #206

andrewnguyen22 opened this issue Sep 12, 2022 · 1 comment
Assignees
@andrewnguyen22
Labels
code health Nice to have code improvement core Core infrastructure - protocol related
Milestone
M1: Pocket PoS (P...

Comments

@andrewnguyen22
Copy link
Contributor

Objective

Discuss and agree upon a name for the actor specific parameter that constitutes the ServiceURL and MaxRelays

  • GenericParam
  • ActorSpecificParam

Origin Document

https://github.com/pokt-network/pocket/pull/178/files#r962183571

Goals

  • Find a proper naming convention and make it consistent throughout the entire codebase

Deliverable

  • Code complete implementation
  • Justification of choice

General issue deliverables

  • Update the appropriate CHANGELOG
  • Update any relevant READMEs (local and/or global)
  • Update any relevant global documentation & references
  • If applicable, update the source code tree explanation
  • If applicable, add or update a state, sequence or flowchart diagram using mermaid

[Optional] Testing Methodology

  • _REPLACE_ME: Make sure to update the testing methodology appropriately_
  • Task specific tests: make ...
  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @andrewnguyen22
@andrewnguyen22 andrewnguyen22 added the code health Nice to have code improvement label Sep 12, 2022
@andrewnguyen22 andrewnguyen22 mentioned this issue Sep 12, 2022
Merged
7 tasks
@Olshansk Olshansk added the core Core infrastructure - protocol related label Sep 12, 2022
@Olshansk Olshansk moved this to Backlog in V1 Dashboard Sep 12, 2022
@andrewnguyen22 andrewnguyen22 changed the title [Consolidate] GenericParam & ActorSpecificParam with one semantic name [TECHDEBT] GenericParam & ActorSpecificParam with one semantic name Sep 24, 2022
@andrewnguyen22
Copy link
Contributor Author

closed with #178

Repository owner moved this from Backlog to Done in V1 Dashboard Oct 10, 2022
This was referenced Oct 19, 2022
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewnguyen22 andrewnguyen22

Labels
code health Nice to have code improvement core Core infrastructure - protocol related
Projects
V1 Dashboard
Status: Done
Milestone
M1: Pocket PoS (Proof of Stake)
Development

No branches or pull requests
2 participants
@Olshansk @andrewnguyen22