Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark(python): Shift polars TPC-H benchmarks to main repo and include in CI #7740

Open
chitralverma opened this issue Mar 23, 2023 · 2 comments
Open

benchmark(python): Shift polars TPC-H benchmarks to main repo and include in CI #7740

chitralverma opened this issue Mar 23, 2023 · 2 comments
Labels
ci Related to the continuous integration setup enhancement New feature or an improvement of an existing feature performance Performance issues or improvements

Comments

@chitralverma
Copy link
Contributor

Problem description

This is in reference to a discussion @ritchie46 and I were having on discord regarding the TPC-H benchmarks.

The idea is the following,

  • Implement all 22 TPC-H queries for Polars in the Polars TPC-H repo
  • Move these 22 polars queries alongwith the executor into a benchmark module in this repo
  • Modify CI to include benchmarks via github actions. For this we have following options
    • run on release
    • run on merge to main/ master branch
    • run on PRs

this will clearly show the rate of improvement of the project in terms of performance.
@chitralverma chitralverma added the enhancement New feature or an improvement of an existing feature label Mar 23, 2023
@chitralverma chitralverma changed the title benchmark(python): Shift polars TPC-H benchmarks to main repo and initiate in CI benchmark(python): Shift polars TPC-H benchmarks to main repo and include in CI Mar 23, 2023
@stinodego stinodego added performance Performance issues or improvements ci Related to the continuous integration setup labels Mar 23, 2023
@armgilles
Copy link

Maybe an idea about monitoring performance for polars pytest-codspeed. It's used by pydantic-core and seems pretty easy and robust to use to monitor a bump or regression in terms of performance in CI (exemple pydantic/pydantic-core#337)

@chitralverma
Copy link
Contributor Author

datafusion did something similar i believe

apache/datafusion#6131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Related to the continuous integration setup enhancement New feature or an improvement of an existing feature performance Performance issues or improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stinodego @armgilles @chitralverma