Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logictest: Build arrow records directly #548

Open
thorfour opened this issue Sep 25, 2023 · 9 comments
Open

Logictest: Build arrow records directly #548

thorfour opened this issue Sep 25, 2023 · 9 comments
Labels
good first issue Good for newcomers planned Planned work wont get closed by stalebot

Comments

@thorfour
Copy link
Contributor

Logictests build arrow records by building a parquet record and then using the converter to convert it into an arrow record. Since we no longer support inserting by Parquet records, we should just build the arrow record directly instead.

@thorfour thorfour added the good first issue Good for newcomers label Sep 25, 2023
@elliotchenzichang
Copy link
Contributor

Could I take this?

@thorfour
Copy link
Contributor Author

Could I take this?

Apologies for the slow response. Yes it would be great if you want to take this on. I'll assign the issue to you

@gernest
Copy link
Contributor

gernest commented Dec 14, 2023

Building records directly is simple. However this requires sorting arrow.Record before inserting to the table. Sorting is not implemented in arrow package yet.

I'm contemplating using normal sort.Interface to build indices and use compute.Take , I'm not so sure if it is worthy to implement this to only be used in logictest.

@asubiotto
Copy link
Member

We actually have a lot of use for the ability to sort arrow records in a lot of places. This is (what now seems to be abandoned) work in the arrow project we've been hoping to revive at some point: apache/arrow#34719. If you're up for it and looking for this kind of challenge, it would be fantastic to have this in upstream arrow. If not, a more specific solution would already be very useful to us. Whatever you end up building for logictests would likely also be reused in other places. What you describe sounds good to me.

@asubiotto
Copy link
Member

I also forgot that @metalmatze has a PR open to perform frostdb-specific sorting: #461. We should probably focus on merging that first, although I think that having upstream record sorting would be fantastic.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 15, 2024
@asubiotto asubiotto removed the Stale label Feb 15, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 16, 2024
@asubiotto asubiotto removed the Stale label May 16, 2024
@asubiotto asubiotto added the planned Planned work wont get closed by stalebot label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers planned Planned work wont get closed by stalebot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants