Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package refactoring of Cli, Ant, Maven #69

Merged
merged 6 commits into from
Sep 5, 2015
Merged

Package refactoring of Cli, Ant, Maven #69

merged 6 commits into from
Sep 5, 2015

Conversation

uschindler
Copy link
Member

This PR will refactor the package structure of forbidden-apis:

  • Move all "interfaces" (CLI, ANT, Maven) to separate Java packages. This may help with Split artifact into base, ant, and maven artifacts #66, but is done for better separation
  • For a while, I will keep the AntTask in the main package, because Ant users often use direct package names in their taskdef (instead of the antlib.xml). Those will get a warning message about deprecation
  • I also moved some inner classes out (CliMain's ExitException)

@uschindler uschindler mentioned this pull request Sep 5, 2015
Closed
@uschindler uschindler added this to the 1.9 milestone Sep 5, 2015
@uschindler uschindler self-assigned this Sep 5, 2015
@uschindler uschindler changed the title Features pkg refactor Package refactoring of Cli, Ant, Maven Sep 5, 2015
uschindler added a commit that referenced this pull request Sep 5, 2015
@uschindler
Merge pull request #69 from policeman-tools/features-pkg-refactor
ccfecc1 
Package refactoring of Cli, Ant, Maven
@uschindler uschindler merged commit ccfecc1 into master Sep 5, 2015
@uschindler uschindler deleted the features-pkg-refactor branch September 5, 2015 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@uschindler uschindler

Labels
enhancement
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@uschindler