-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add presence support #151
Add presence support #151
Conversation
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 89.52% 89.56% +0.03%
==========================================
Files 41 42 +1
Lines 6645 6775 +130
==========================================
+ Hits 5949 6068 +119
- Misses 696 707 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
About setting the presence, you might want to add support for set_presence
parameter of the sync API, else it will be reset back to online
whenever we sync.
For sync_forever()
, on every iteration the loop should check some AsyncClient
attribute that gets set when you use set_presence()
, so it knows if it should use a different set_presence
parameter.
@mirukana done, but i think i should move this to the base_client, am i right? PS: Still working on additional tests for the callbacks. |
If you're talking about |
So i added callbacks and tests. |
Regarding 5f2370e, we're looking to drop |
It isn't marked as required in the schema and the type is |
Sounds good. Since this is a new feature I shan't stress too hard about breaking everyone's clients. |
I only added the |
Changed in #155 now takes the |
Yesterday there was the question if nio supports presence/status in the nio matrix room.
So i did a thing :)
Add support for
m.presence
in sync events. SpecAdd support for PresenceEvent callbacks
Add
get_presence
andset_presence
to async clientAdd
presence
,last_active_ago
,currently_active
andstatus_msg
fields to MatrixUser