Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0 runtimes #20

Closed
bkchr opened this issue Aug 28, 2023 · 18 comments
Closed

Release 1.0 runtimes #20

bkchr opened this issue Aug 28, 2023 · 18 comments

Comments

@bkchr
Copy link
Contributor

bkchr commented Aug 28, 2023

The repository should now be prepared enough to create the first runtime release from this repo. Parity released all crates alongside releasing the 1.0 release of the node. As the 1.0 release is now already out for some time, I propose that we do the runtimes 1.0 release based on the next Parity Polkadot node release.

So, we first need to wait for this next node release to happen. After the release happened, someone can propose a pull request that updates to these crates on crates.io.

CC @ggwpez @coderobe

@bkchr
Copy link
Contributor Author

bkchr commented Aug 28, 2023

BTW, this time we don't want to copy the commits as before. From this point on this repo will work independently from the Parity repos when it comes to updating the runtimes. The runtimes in this repo are also the canonical ones.

@ggwpez
Copy link
Member

ggwpez commented Aug 28, 2023

So, we first need to wait for this next node release to happen. After the release happened, someone can propose a pull request that updates to these crates on crates.io.

Replacing the dependencies to use crates-io instead of git? okay.

BTW, this time we don't want to copy the commits as before. From this point on this repo will work independently from the Parity repos when it comes to updating the runtimes. The runtimes in this repo are also the canonical ones.

😌 so just copying the changes instead of the full history?

@bkchr
Copy link
Contributor Author

bkchr commented Aug 28, 2023

o just copying the changes instead of the full history?

Yes

Replacing the dependencies to use crates-io instead of git? okay.

I mean I hope we get the latest release this week on crates.io, otherwise we need to use git dependencies.

@acatangiu
Copy link
Contributor

What’s the timeline here? When can we expect a new runtime release?

Seeing how node v1.1.0 is out should we not release runtimes 1.1.0 directly (instead of v1.0)?

@bkchr
Copy link
Contributor Author

bkchr commented Sep 19, 2023

#28 it is being worked on here.

And yes it will be passed on 1.1.0.

@acatangiu
Copy link
Contributor

#28 was merged. Can we do a release now? We need a runtime release for BEEFY on Kusama.
Anything I can help with getting this over the finish line?

@bkchr
Copy link
Contributor Author

bkchr commented Oct 9, 2023

We need to wait for the staking changes runtime upgrade to be approved. After that is approved, we need to merge this fix here to make the repo canonical again. Then we can bring the release over the finish line. I think we can actually do that before the fix is enacted on chain, but we should be certain that it gets enacted on chain.

Maybe we can then do the next release faster...

@acatangiu
Copy link
Contributor

Ok, thanks for the context! 👍

@bkchr
Copy link
Contributor Author

bkchr commented Oct 17, 2023

So, I would like to merge the following pr first: #63

After this pr is merged, we can update this pr #26 and then finally do the release.

@joepetrowski
Copy link
Contributor

joepetrowski commented Oct 17, 2023

Also required:

@NachoPal
Copy link
Contributor

Reason why Parachains stall after relay chain runtime upgrade: paritytech/polkadot-sdk#1923 (comment)

@kianenigma
Copy link
Contributor

No action item needed for paritytech/polkadot-sdk#125 in this release.

Context: VoteLockingPeriod was mistakenly set to 7 days, and in this release it is going back to 28, the value that it should be. This will not impact the user's voting power. At the moment, the lock can be removed sooner than expected in Polkadot. Once we fix this, the locks will be according to the spec. Implementing polkadot-fellows/RFCs#20 (comment) is a different concern and probably will need consideration, but is outside the scope of this release.

@bkchr
Copy link
Contributor Author

bkchr commented Oct 18, 2023

We should not forget to bump the spec_versions.

@acatangiu
Copy link
Contributor

Let's also get

released.

We want to go live with the Polkadot<>Ethereum bridge by end of year, meaning BEEFY should be active on Polkadot before December.
And activating it has a long tail of actions:

  1. release runtime
  2. upgrade runtime
  3. coordinate validators to rotate keys (register BEEFY keys)
  4. governance to enable BEEFY

If we include it in this release we can do 1-3 in parallel for Kusama and Polkadot. Then do 4 on Polkadot once we're happy with stability on Kusama.

Waiting for next release means doing 1->4 between next release and end of December which won't be possible unless fellowship does another release 2, max 3 weeks from now...

@bkchr
Copy link
Contributor Author

bkchr commented Oct 19, 2023

No this will not be included anymore. This can go into the next release. We want to start with the next release shortly after this was has finally be dine (which is hopefully today).

@bkchr
Copy link
Contributor Author

bkchr commented Oct 19, 2023

To not break every downstream user as we have renamed the xcm crate to staging-xcm to have it released on crates.io, I have created the following two prs:

With these two prs we will have TypeInfo::path not return staging-xcm as one segment and instead xcm. So, the metadata type name shouldn't change and downstream users should not need to change anything. A proper solution is being discussed here: polkadot-js/api#5741 TLDR: Do not reference the type by name as there might be dragons ;)

We will require that both prs are merged and the appropriate crates being relased. For the staging-xcm crate we will need to backport the changes to 1.1.0 and 1.2.0 and release a patch release of the staging-xcm crate.

@bkchr bkchr removed this from the 1.0.0 milestone Oct 19, 2023
@bkchr
Copy link
Contributor Author

bkchr commented Oct 23, 2023

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants