Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail when author pushes new code should check if the user is not a fellow #372

Closed
Bullrich opened this issue Jul 2, 2024 · 1 comment
Closed

Comments

@Bullrich
Copy link
Contributor

Bullrich commented Jul 2, 2024

The changed introduced in #76 has an error.

The system should check if the user is not a fellow.

The following change should be done in review-trigger.yml

+           !contains(steps.fellows.outputs.github-handles, github.event.pull_request.user.login)
-           contains(steps.fellows.outputs.github-handles, github.event.pull_request.user.login)

Skip high ranking fellow

A new requirement to introduce with this fix is that it should skip the check if the author is rank 3 or higher.

@Bullrich Bullrich changed the title Fail when author pushes new code should check if the user **is not** a fellow Fail when author pushes new code should check if the user is not a fellow Jul 2, 2024
@Bullrich
Copy link
Contributor Author

Bullrich commented Jul 3, 2024

Solved in #369

@Bullrich Bullrich closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant