Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate integrating tx signing with the gas handling antehandler changes #132

Open
Tracked by #204
natebeauregard opened this issue Aug 13, 2024 · 1 comment

Comments

@natebeauregard
Copy link
Collaborator

#123 introduced a way for the monomer adapters to optionally produce signed transactions. However, this requires passing application specific context into monomer and generating a monomer specific private key to sign with.

As we gain more context on working with a custom antehandler/decorator for bypassing the deposit tx gas in #107, we should also investigate if bypassing tx signing could be included as well as.

If the investigation doesn't lead us to bypassing signing for deposit txs in the antehandler, we should instead look into only passing through specific parts of the app context that are relevant and should add unit tests for verifying the monomer tx signer behavior.

@natebeauregard
Copy link
Collaborator Author

@joshklop Created this issue based on our conversation during the daily meeting, feel free to elaborate on anything in here

@natebeauregard natebeauregard changed the title Investigate integrating transaction signing with the gas handling antehandler changes Investigate integrating tx signing with the gas handling antehandler changes Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant