Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Spotlight and Explore configuration to a separate JSON file #2110

Open
kimrutherford opened this issue Nov 2, 2023 · 3 comments
Open
Assignees

Comments

@kimrutherford
Copy link
Member

kimrutherford commented Nov 2, 2023

The main config file is getting quite big and half of it is the Spotlight and Explore configuration. It makes sense to split into smaller more manageable files.

Once that's done we can think about avoiding loading the full Spotlight config in the webapp until the user visits the Spotlight archive page. This is make initial webapp loading a little faster and will use less memory in the browser.


Note to self: remove panel_type, instead add spotlight_panels.json and explore_panels.json. Add community_panels to the main config file.

@kimrutherford kimrutherford self-assigned this Nov 2, 2023
@ValWood
Copy link
Member

ValWood commented Nov 2, 2023

I like this plan. If you could also put the Spotlights below Explore, when we add spotlights we can just zoom to the bottom of the file, The longest part of this task for me now is locating the correct place in the file.

@kimrutherford
Copy link
Member Author

The longest part of this task for me now is locating the correct place in the file.

What I do is go to the end of the file then search backwards for "spotlight"

@ValWood
Copy link
Member

ValWood commented Nov 17, 2023

doh ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants