Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed percentageLabel to use time estimate, instead of percentage o… #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nickfinestead
Copy link

@nickfinestead nickfinestead commented Sep 6, 2024

I changed the formatting for the Desktop top bar label to show the formatting in "hh mm (ex. 0h 28m)". I'm currently on GNOME 46.0 and tested that this works as expected. I also added a comment to make it easier to find.

This should close #3

Please let me know if I need to change or fix anything

@nickfinestead
Copy link
Author

Something small I've noticed is that when the system is at 100% and charging there is no time estimate because result === 0 due to this._proxy.TimeToEmpty === 0 (technically because the system still is in the charging state) and this._proxy.TimeToFull === 0 so looking into a fix for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show battery time in top bar
1 participant