Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference implementation fails to reject pulses with a proportion of zero #166

Closed
grahamgower opened this issue Nov 17, 2024 · 2 comments
Closed

Comments

@grahamgower
Copy link
Member

We have no test cases with a pulse proportion of zero, and the reference implementation erroneously accepts such pulse proportions. Reported by @molpopgen over at popsim-consortium/demes-python#576

@grahamgower
Copy link
Member Author

It looks like this issue also affects ancestry proportions. I.e. the following is accepted but should not be.

time_units: generations
demes:
- name: a
  epochs:
  - {start_size: 100, end_time: 50}
- name: b
  epochs:
  - {start_size: 100, end_time: 50}
- name: c
  ancestors: [a, b]
  proportions: [0.0, 1.0]
  start_time: 100
  epochs:
  - {start_size: 100}

@grahamgower
Copy link
Member Author

Fixed by #167.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant