Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification of String and Array behavior for plan exports #268

Closed
Tracked by #264
pengyin-shan opened this issue Nov 25, 2022 · 1 comment
Closed
Tracked by #264

Clarification of String and Array behavior for plan exports #268

pengyin-shan opened this issue Nov 25, 2022 · 1 comment
Assignees

Comments

@pengyin-shan
Copy link

pengyin-shan commented Nov 25, 2022

Found this in the middle of rubocop fix:
Running rspec ./spec/features/plans/exports_spec.rb after fixing the export_plan.rb are seeing following issue:
Screenshot 2022-11-25 at 4 00 02 PM

May need to discuss this with the main code team, since it seems that we are using different data properties to define some export setting

@pengyin-shan pengyin-shan self-assigned this Nov 25, 2022
@pengyin-shan
Copy link
Author

Fixed by change the line 4 of _plan_text.erb to <%= Array(@hash[:attribution]).many? ? _("Creators: ") + Array(@hash[:attribution]).join(", ") : _('Creator:') + @hash[:attribution] %>. The commit will be part of #264 PR. Close this issue as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant