Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-Merge Testing of Upstream Releases v4.0.0, v4.0.1, and v4.0.2 #465

Closed
aaronskiba opened this issue Sep 29, 2023 · 1 comment · Fixed by #474
Closed

Post-Merge Testing of Upstream Releases v4.0.0, v4.0.1, and v4.0.2 #465

aaronskiba opened this issue Sep 29, 2023 · 1 comment · Fixed by #474
Assignees

Comments

@aaronskiba
Copy link
Collaborator

This issue has been created for the purpose of documenting manual tests performed against the merges of upstream releases v4.0.0, v4.0.1, and v4.0.2.

@aaronskiba aaronskiba self-assigned this Sep 29, 2023
@aaronskiba aaronskiba changed the title Post-Merge Testing of Upstream Releases v4.0.0, v4.0.1, v4.0.2 Post-Merge Testing of Upstream Releases v4.0.0, v4.0.1, and v4.0.2 Sep 29, 2023
@aaronskiba
Copy link
Collaborator Author

aaronskiba commented Sep 29, 2023

v4.0.0

Changes Outlined in v4.0.0 Release

  • "Updated the PDF coversheet to include all Contributors"

    • TEST
      1. Create a plan
      2. Add 2 contributors
        Screenshot from 2023-09-29 10-32-51
      3. Download the plan and ensure the two contributors and their correct roles are displayed
        Screenshot from 2023-09-29 10-35-24
    • RESULTS
      1. The contributors and their roles are visible on the downloaded plan.
      2. HOWEVER, there are duplicate occurrences of them within the downloaded plan. (TODO: Check further upstream releases to see if this bug has been addressed).
        NOTE:
      3. The duplicate occurrences don't occur with the release v4.0.0 version of the upstream app.
        Screenshot 2023-09-29 at 3 55 04 PM
    • UPDATE
      1. There was duplicate code in app/views/shared/export/_plan_coversheet.erb. Removing the duplicate code removed the duplicate listings of contributors.
        Screenshot from 2023-09-29 16-11-57
  • "Fixed an issue that was causing the link to organizational guidance to repeat"

    • TEST (I hope I am testing the correct "link to organizational guidance")

      1. As an admin, create and publish a guidance for the organisation. Check all themes.
        Screenshot from 2023-09-29 12-16-27
      2. Create a new template for the organisation. Add a phase, a question, and a theme for the question.
        Screenshot from 2023-09-29 12-32-09
      3. Publish the template
        Screenshot from 2023-09-29 12-33-40
      4. Create a plan. Select the organisation and the newly published template.
        Screenshot from 2023-09-29 12-35-08
      5. Ensure there are no repeat links to organizational guidance.
        Screenshot from 2023-09-29 12-35-49
    • RESULTS

      1. Unfortunately, there is a repeat link to the Portage Network organisation.
    • NOTE

      1. This problem DOES NOT seem to exist prior to merge of v4.0.0 release
      2. In GET /plans/show (app/controllers/plans_controller.rb) @important_orgs seems to include duplicate entries.
      3. This issue also seems to exist on the upstream app for release v4.0.0 ( and the bug persists for release v4.1.0)
        Screenshot 2023-09-29 at 3 47 56 PM
  • "Fixed an issue that was impacting API v0 and preventing the batch assignment of users to departments"

    • TEST

      1. Assign multiple users to a department and verify the assignment.
        Screenshot from 2023-10-02 15-10-34
        Screenshot from 2023-10-02 15-11-01
      1. Unassign these same users from the department and verify the unassignment.
        Screenshot from 2023-10-02 15-11-40
        (The emails now belong to the followingnull department):
        Screenshot from 2023-10-02 15-17-07
    • RESULTS

  • "Fixed an issue that was preventing admins from performing a search on the Templates page Template Search issue DMPRoadmap/roadmap#3217"

    • TEST

      1. As an admin, navigate to templates.
      2. Type 'test' in the search bar and inspect the returned results
        Screenshot from 2023-09-29 14-02-40
    • RESULTS

      1. Templates search appears to be working.
  • Removed case sensitivity from the validation rules for Org and Department names.

    • TEST

    • RESULTS

  • "Fixed issues with API v1"

    • TEST

    • RESULTS

  • "Fixed an issue that was causing plans that were based off of templates with conditional questions to disappear when the user triggered the condition Conditional questions causing plans to disapear  DMPRoadmap/roadmap#3163"

    • TEST

    • RESULTS

  • "Fixed an issue that was causing plans to not appear in the publicly visible if 100% of their questions had not been answered Org visibility plan will appear in the public DMPs only if filled 100% DMPRoadmap/roadmap#3086"

    • TEST

    • RESULTS

v4.0.1

Changes Outlined in v4.0.1 Release

v4.0.2

Changes Outlined in v4.0.2 Release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant