Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change label to Plan visibility public plan #81

Closed
lagoan opened this issue Dec 1, 2021 · 6 comments
Closed

Change label to Plan visibility public plan #81

lagoan opened this issue Dec 1, 2021 · 6 comments
Assignees

Comments

@lagoan
Copy link
Collaborator

lagoan commented Dec 1, 2021

Expected behaviour:

We need to clarify what public visibility will mean for public created plans.

We should change the description to:

Public: this will make plans publicly available from Public DMPs page, viewable and downloadable by other users

Actual behaviour:

Currently, the plan visibility description says Public: anyone can view

image

Steps to reproduce:

Log in
From the dashboard select a created plan
From the Plan, view click on the Share tab
The set plan visibility will have the list of visibilities available for plans.

@pengyin-shan
Copy link

@lagoan just to confirm, we don't have a translation for 'this will make plans publicly available from Public DMPs page, viewable and downloadable by other users' in translation.io yet, should I discuss this sentence with any professional translator? Or I continue to use the one-word translation such as 'Público'?

@pengyin-shan
Copy link

@lagoan : I tested the translation in dmp-assistant-test project as following:
Screen Shot 2021-12-03 at 5 00 39 PM
But I didn't do anything to dmp-assistant project in case I disrupt the production version. So in order to get a correct translation in dmp-assistant, should I just add the sentence and msg Robyn for her approval?

@lagoan
Copy link
Collaborator Author

lagoan commented Dec 3, 2021

The translation files need to be resynched after they are updated in translation.io . Curerently this requires running a rake task to download the new content.

For now, I would suggest contacting @robynnicholson to make sure that translation is handled by our team of translators.

We will not be working on the translation side of the project unless it requires technical input.

I believe the rake task is rake translation:sync. Before running it make sure the api token points to the test project.

Let me know if I can clarify anything.

@pengyin-shan
Copy link

@lagoan Got it. Yeah I ran the rake translation:sync and got the translation I need in development environment for dmp-assistant-test.

So I think my next step is to contact @robynnicholson to confirm the translation in dmp-assitant-test, then after she confirmed, I can sync with dmp-assistant to make the new term being uploaded to dmp-assistant. I then add the same translation and sync again with dmp-assistant this time. Is this the workflow I should go?

@lagoan
Copy link
Collaborator Author

lagoan commented Dec 3, 2021

For now just to have her double check the translation
We will update the translation in the production project once everything is translated

For now don't update the translation files

This was referenced Dec 8, 2021
@pengyin-shan
Copy link

Changes merged to integration branch and deployed in uat. Close this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants