Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add popover information to Organization details view #82

Closed
lagoan opened this issue Dec 1, 2021 · 5 comments
Closed

Add popover information to Organization details view #82

lagoan opened this issue Dec 1, 2021 · 5 comments
Assignees

Comments

@lagoan
Copy link
Collaborator

lagoan commented Dec 1, 2021

We need to clarify what Organization type(s) means on the Organization details page.

Add Floatover Text for "Organization type(s)" field on Organization details page (e.g., "This information can only be changed by a system administrator. Contact support@portagenetwork.ca if you have questions or to request changes.")

The floatover text should appear in the same what that the floatover text appears for Organization URLs.

To see this view

  • Log into the system as an organizational administrator
  • On the Admin menu select Organization details
  • Scroll down to see Organization type(s)

image

@pengyin-shan
Copy link

pengyin-shan commented Dec 6, 2021

@lagoan I made the change using example string This information can only be changed by a system administrator. Contact support@portagenetwork.ca if you have questions or to request changes.in the branch issue82, just want to confirm we gonna to also need a translation for this string right (I will update translation.io and add tag)? Or I should ask Robyn to propose a new English string first?

@lagoan
Copy link
Collaborator Author

lagoan commented Dec 6, 2021

That is great!
When making the change of text, make sure you are using Rails.configuration.x.organisation.email to fetch the email address, we may change the contact email at some point and it would be great if there if we need to change it in only one place (I do know that it is hardcoded in other areas but we should avoid it whenever possible).

We will need the translated string. For now, synchronize the translation files and tag the new key.

@pengyin-shan
Copy link

@robynnicholson
Copy link

@pengyin-shan @lagoan Hi both, just following up on this issue, the translation has been added and verified in the dmp-assistant-test project on translation.io. Thanks!

@pengyin-shan
Copy link

Great, I will close this ticket then, thanks for confirmation!

@pengyin-shan @lagoan Hi both, just following up on this issue, the translation has been added and verified in the dmp-assistant-test project on translation.io. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants