Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org indentation not right #22

Closed
jdtsmith opened this issue Dec 20, 2023 · 8 comments
Closed

org indentation not right #22

jdtsmith opened this issue Dec 20, 2023 · 8 comments

Comments

@jdtsmith
Copy link
Contributor

jdtsmith commented Dec 20, 2023

org-indent adds level based indentation automatically. You seem to have pre-indented things "by hand". This is OK but leads to double-indentation, and breaks things like org-modern-indent:

image
@psionic-k
Copy link
Member

I made this a while ago and also abandoned indentation. PR welcome.

@jdtsmith
Copy link
Contributor Author

See #23.

@psionic-k
Copy link
Member

I manually pushed your changes and did a lot of edits on top. Re-open if there's an issue with the result.

I ended up making a surprising number of edits.

Anyway the combination of visual-line-mode, visual-fill-column, and adaptive-wrap are perfect

@jdtsmith
Copy link
Contributor Author

jdtsmith commented Jan 8, 2024

If you use org-indent, adaptive wrapping is "built in". It's looking good:

image

@jdtsmith
Copy link
Contributor Author

jdtsmith commented Jan 8, 2024

BTW in the EIEIO section I noticed uses of (plist-get (symbol-plist 'magit-dispatch) 'transient--prefix), which can be shortened to (get 'magit-dispatch 'transient--prefix).

@psionic-k
Copy link
Member

That's hot. Thanks.

@jdtsmith
Copy link
Contributor Author

jdtsmith commented Jan 8, 2024

I always thought it was funny that the very primitive and basic-sounding get and put access a type of symbol metadata most elisp programmers don't get around to using for a long time!

@psionic-k
Copy link
Member

I didn't even mention that in the Elisp Idiosyncrasies video I did, and I touched on symbol-plists: https://youtu.be/D8391afYiRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants