From 0a37ac5185b2c4521c8e4036358755c004ba123b Mon Sep 17 00:00:00 2001
From: Christian Sahlmann <christian.sahlmann@telekom.de>
Date: Wed, 12 Jul 2023 13:40:15 +0200
Subject: [PATCH] log information when SNMP packet cannot be decoded

---
 mb_netmgmt/__init__.py | 2 +-
 mb_netmgmt/snmp.py     | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/mb_netmgmt/__init__.py b/mb_netmgmt/__init__.py
index 6bc550e..3b2fec1 100644
--- a/mb_netmgmt/__init__.py
+++ b/mb_netmgmt/__init__.py
@@ -18,7 +18,7 @@
 # along with mb-netmgmt. If not, see <https://www.gnu.org/licenses/
 
 """Network Management Protocols for Mountebank"""
-__version__ = "0.0.66"
+__version__ = "0.0.67"
 
 import os
 import subprocess
diff --git a/mb_netmgmt/snmp.py b/mb_netmgmt/snmp.py
index f013298..498436d 100644
--- a/mb_netmgmt/snmp.py
+++ b/mb_netmgmt/snmp.py
@@ -18,11 +18,13 @@
 # along with mb-netmgmt. If not, see <https://www.gnu.org/licenses/
 
 import binascii
+import logging
 from base64 import b64decode, b64encode
 from socket import SOCK_DGRAM, socket
 from socketserver import DatagramRequestHandler, ThreadingUDPServer, UDPServer
 
 from scapy.asn1.asn1 import ASN1_Class_UNIVERSAL
+from scapy.asn1.ber import BER_Decoding_Error
 from scapy.layers.snmp import SNMP, SNMPbulk, SNMPresponse, SNMPvarbind
 
 from mb_netmgmt.__main__ import Protocol
@@ -60,7 +62,11 @@ def open_upstream(self, to):
 
     def read_proxy_response(self):
         bytes_response = self.upstream_socket.recv(UDPServer.max_packet_size)
-        snmp_response = SNMP(bytes_response)
+        try:
+            snmp_response = SNMP(bytes_response)
+        except BER_Decoding_Error:
+            logging.error(bytes_response)
+            raise
         result = dict()
         for varbind in snmp_response.PDU.varbindlist:
             result[varbind.oid.val] = {