This repository has been archived by the owner on Jun 6, 2022. It is now read-only.
Allow custom media to reference each other #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good. |
| @@ -1,3 +1,4 @@ | |||
| @custom-media --a (--a); | |||
There was a problem hiding this comment.
It's used by the "should transform custom media with self reference" test.
There was a problem hiding this comment.
Sorry I don't see how. No import or something in test/fixtures/transform-self-reference.css
There was a problem hiding this comment.
Oh, you are right. It's been awhile and I have no idea why this file exists. Let me double check.
|
Please remove the unused fixtures and rebase on master so I can merge. |
|
PTAL |
|
Nice. |
MoOx
added a commit
that referenced
this pull request
Jun 30, 2015
Allow custom media to reference each other
|
Released as 4.1.0 |
|
Thanks. I will send the cssnext PR soon. |
|
This PR fixes #9. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final missing piece. :)
Any plan on settling the option name? I plan to submit the extract pr once it's resolved.