Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutex.h: Update for MSC 1938 compat #97

Closed

Conversation

johnwparent
Copy link

MSC 1938 removes native_handle from the API.
Remove reference in mutex.h

MSC 1938 removes `native_handle` from the API.
Remove reference in mutex.h
@BenKaufmann
Copy link
Contributor

@johnwparent Thank you for making me aware of this issue 👍

This is truly a weird API break from MS, which judging from microsoft/STL#3770 (comment) and https://learn.microsoft.com/en-us/cpp/standard-library/mutex-class-stl?view=msvc-170#native_handle they also forgot to document 😞

However, given that according to C++ standard these members are indeed optional, I pushed a more general fix to clasp's dev branch, which is the branch were development happens.

@johnwparent
Copy link
Author

@BenKaufmann Thanks for merging in a fix!

This is truly a weird API break from MS
Thoroughly perplexing choice on the part of MS, particularly considering how devoted to backwards compat they typically are. Thankfully it was such a break it was pretty easy to find.

Apologies for the patch, should have just gone with the generic "re-implementation", didn't realize that parts of Clasp depend on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants