Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix when value is relation, but set as null #318

Merged
merged 1 commit into from
Sep 25, 2018
Merged

fix when value is relation, but set as null #318

merged 1 commit into from
Sep 25, 2018

Conversation

chengz
Copy link
Contributor

@chengz chengz commented Sep 25, 2018

Closes #315.

Handle nested property, especially relation, when set to null

snewcomer
snewcomer approved these changes Sep 25, 2018
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks @chengz

@snewcomer snewcomer merged commit 462e677 into adopted-ember-addons:master Sep 25, 2018
@nickschot nickschot mentioned this pull request Dec 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

belongsTo not properly emptying when set to null
3 participants
@chengz @snewcomer @SergeAstapov