Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validationMap type signature #352

Merged
merged 1 commit into from
May 24, 2019
Merged

Fix validationMap type signature #352

merged 1 commit into from
May 24, 2019

Conversation

matteodepalo
Copy link
Contributor

Changes proposed in this pull request

At the moment Typescript complication fails if the validationMap is an object with arrays as values, which valid syntax.

E.g.

export default {
  firstName: [
    validatePresence(true),
    validateLength({ min: 4 })
  ]
}

This change fixes the compilation error.

snewcomer
snewcomer approved these changes May 24, 2019
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woop woop!

@snewcomer snewcomer merged commit 8e95bb4 into adopted-ember-addons:master May 24, 2019
@matteodepalo matteodepalo deleted the patch-1 branch May 24, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteodepalo @snewcomer @SergeAstapov