Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG.md #388

Merged
merged 1 commit into from
Dec 24, 2019
Merged

Update CHANGELOG.md #388

merged 1 commit into from
Dec 24, 2019

Conversation

SergeAstapov
Copy link
Contributor

Updates CHANGELOG.md with notes for 2.2.x versions

snewcomer
snewcomer approved these changes Dec 24, 2019
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not keeping up with this and thank you!

@snewcomer snewcomer merged commit 9d58337 into adopted-ember-addons:master Dec 24, 2019
@SergeAstapov SergeAstapov deleted the patch-1 branch December 24, 2019 17:28
@SergeAstapov
Copy link
Contributor Author

@snewcomer do you think introduction of lerna-changelog and release-it (similar to what projects like ember-template-lint do) would be desirable?

@snewcomer
Copy link
Collaborator

I'd be fine with it! What does the install/setup time look like? Should we file an issue to do or is it pretty straightforward to setup?

@SergeAstapov
Copy link
Contributor Author

@snewcomer I haven't done that setup yet, so I'm pretty unfamiliar.
I don't mind to file an issue and work on it as I'm pretty interested to have experience with such kind of tools. Though can't promise to finish it soon

@snewcomer
Copy link
Collaborator

snewcomer commented Dec 24, 2019 •
edited
Loading

That sounds good! No rush. #389

@herzzanu
Copy link
Contributor

herzzanu commented Feb 4, 2020

@SergeAstapov @snewcomer I can do this if you didn't start working on it. I've done it before and it's pretty trivial. Let me know.

@snewcomer
Copy link
Collaborator

@herzzanu That would be lovely! I was hoping to learn from one of you on how to do it!

@herzzanu
Copy link
Contributor

herzzanu commented Feb 6, 2020

@snewcomer Awesome, just opened #426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SergeAstapov @snewcomer @herzzanu