Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another safeSet for Ember happiness #397

Merged
merged 1 commit into from
Jan 11, 2020
Merged

Another safeSet for Ember happiness #397

merged 1 commit into from
Jan 11, 2020

Conversation

snewcomer
Copy link
Collaborator

@snewcomer snewcomer commented Jan 11, 2020 •
edited
Loading

close #394 #396

@snewcomer snewcomer added the bug label Jan 11, 2020
@snewcomer snewcomer self-assigned this Jan 11, 2020
@snewcomer snewcomer mentioned this pull request Jan 11, 2020
Merged
@snewcomer snewcomer merged commit 5a9ccee into master Jan 11, 2020
@snewcomer snewcomer deleted the sn/safe-set-again branch January 11, 2020 04:20
@josemarluedke
Copy link
Contributor

This PR did solve #394. However, it did not affect anything in #396 as that is a separate issue.

Thanks for working on this so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snewcomer snewcomer

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3.0.0-beta.4] mutating the model in Glimmer Components
2 participants
@snewcomer @josemarluedke