Add set test #401
Add set test #401
Conversation
| assert.equal(c.get('org.usa.mn'), 'undefined'); | ||
| assert.equal(dummyModel.org.usa.ny, 'nil2'); | ||
| assert.equal(dummyModel.org.usa.mn, 'undefined'); | ||
| }); |
There was a problem hiding this comment.
@josemarluedke Does this test look right to you?
There was a problem hiding this comment.
Yep. Looks good! Interesting that it is passing. Not sure how to capture that bug in a test then.
README.md
Outdated
| <Input @value={{changeset.lastName}} /> | ||
| <input | ||
| value={{model.firstName}} | ||
| oninput={{action (changeset-set this.changeset "model.lastName") value="target.value"}}> |
There was a problem hiding this comment.
@josemarluedke Do these README updates look ok to you? ie. the model as the value as noted #398 (comment)
There was a problem hiding this comment.
I don't think this change is correct. I believe forms should always reflect the in-flight model. This way, we can revert changes and have forms reflect it without any issues. Also, If you have a form in a tab layout for example, and you hide half of the form then go back to that, the form would show the incorrect data, the user would think they have lost their changes.
There was a problem hiding this comment.
reverted. Thanks a ton for the insight.
This reverts commit b9349c4.
adopted-ember-addons/validated-changeset#9 (comment)