Add failing test for nested properties with booleans #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josemarluedke
force-pushed
the
add-failing-test-for-checkbox
branch
from
6ae74c4 to
24e6e0d
Compare
snewcomer
reviewed
Jan 20, 2020
josemarluedke
force-pushed
the
add-failing-test-for-checkbox
branch
from
24e6e0d to
f4ec285
Compare
|
@josemarluedke I think I know what we can do. We check if the old content value is equal to what we want to set and if so, don't do anything. I'll see if we can refactor this. |
|
#416 partially fixed your issues. I think there might be something else we need to do! |
Merged
|
Ok everything should be g2g on master! Can't thank you enough for your contributions. These were also issues in 2.x and 1.x so these are very nice additions! Feel free to merge in master and we can get this PR merged! |
josemarluedke
force-pushed
the
add-failing-test-for-checkbox
branch
from
f4ec285 to
ddd15b5
Compare
|
Rebased with master, tests did pass locally. Thank you @snewcomer for working on fixing this. Should we get these tests merged anyway? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test for a bug I encountered today.
cc/ @snewcomer