enhancement Add types to app folder as well #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or since this is at build time, you would reference |
|
@snewcomer Yeah, in the app folder would not work either. I believe it needs to be on the root folder. eg. |
|
That makes a lot more sense :) |
|
I just tested here and moving to root does work correctly. |
josemarluedke
approved these changes
Feb 12, 2020
types/index.d.ts
Outdated
| @@ -0,0 +1,20 @@ | |||
| import { | |||
There was a problem hiding this comment.
Should we also remove this file from addon/types/index.d.ts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will work so you don't have to reach into
addon/typesto import. ember-cli will look for it in theapp/namespace I believe. @josemarluedke Lmk if you have the same thought as well.ref #424