Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TS errors #641

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Fix TS errors #641

merged 1 commit into from
Feb 16, 2022

Conversation

bartocc
Copy link
Contributor

@bartocc bartocc commented Feb 16, 2022

  • Add return types for changeset and Changeset functions
  • Properly add changeset member to 4th argument type

Closes #639

@bartocc
Fix TS errors
f823774 
- Add return types for `changeset` and `Changeset` functions
- Properly add `changeset` member to 4th argument type
@bartocc bartocc mentioned this pull request Feb 16, 2022
Closed
@snewcomer snewcomer merged commit ea72463 into adopted-ember-addons:master Feb 16, 2022
@bartocc bartocc deleted the patch-1 branch February 16, 2022 17:37
@SergeAstapov SergeAstapov mentioned this pull request Feb 21, 2022
Merged
@snewcomer snewcomer added the bug label Feb 21, 2022
@bartocc bartocc mentioned this pull request Apr 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript errors in 4.0.0-beta.4
2 participants
@bartocc @snewcomer