Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump validated-changeset 1.2.0 #646

Merged

Conversation

sapryniukt
Copy link
Contributor

No description provided.

@@ -42,7 +42,7 @@
"@glimmer/tracking": "^1.0.4",
"ember-auto-import": "^2.3.0",
"ember-cli-babel": "^7.26.6",
"validated-changeset": "~1.1.2"
"validated-changeset": "~1.2.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this significantly changed the package-lock file. Should be limited changes. Probably npm install isn't respecting the Volta version in package.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-03-21 at 12 30 49 PM

@snewcomer looks like it's actually valid? GitHub does not like lock files :)

Copy link
Collaborator

@snewcomer snewcomer Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now its right. It wasn't before. It was bumped to lock file version 2, which would be node 14 or 16

@snewcomer snewcomer merged commit aac0b2c into adopted-ember-addons:master Mar 21, 2022
@sapryniukt sapryniukt deleted the bump-validated-changeset branch March 21, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants