Add onDestroy callback method for flash object destroy #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scanieso
force-pushed
the
add-onDestroy-callback
branch
from
e581ab0 to
41ee7df
Compare
|
☔ The latest upstream changes (presumably f5002eb) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Ran into a scenario where I need this functionality - @scanieso This looks a couple months old, would you by any chance have time to fix the merge conflicts so that the collaborators can merge it? If not, I can clean it up for merge. |
scanieso
force-pushed
the
add-onDestroy-callback
branch
2 times, most recently
from
712118d to
ce0c46e
Compare
scanieso
force-pushed
the
add-onDestroy-callback
branch
from
ce0c46e to
4d3671c
Compare
scanieso
changed the title
|
Thanks for the ping @patrickng . Updated and ready for review. |
sbatson5
reviewed
Jan 7, 2017
👍| @@ -144,6 +144,12 @@ Ember.get(this, 'flashMessages').success('This is amazing', { | |||
|
|
|||
| By default, flash messages will be destroyed on click. Disabling this can be useful if the message supports user interaction. | |||
|
|
|||
| - `onDestroy: function` | |||
There was a problem hiding this comment.
Would you mind also adding an example of this on line 90?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a callback function that can be passed in and called when a flash is destroyed.
Addresses: #212