leave message on mouseover if sticky #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbatson5 any plans for a patch release soon? I just ran into this issue in production code. |
|
@mnoble01 The PR is open for 1.4.1. Unfortunately, I don't have npm access, so I can't publish it myself. Will ping @poteto. In the meantime, you can reference the commit directly in your
|
|
Thanks, @sbatson5 |
|
@mnoble01 looks like 1.4.1 is published thanks to @Dhaulagiri |
|
@sbatson5 Yes, thanks to you both for the quick turnaround. I've already upgraded to 1.4.1 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #222
The method to defer our timers wasn't checking to see if that object was sticky. This PR adds an early return to the timer methods and test to ensure they are not called.