-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extendTimeout on sticky message #254
Conversation
@sbatson5 I ended up reverting #240 because when reviewing I overlooked the fact that adding ember-concurrency required that dependency to be included in |
Ah, that's why I didn't see it when we pulled it into our existing app (we already had concurrency). We can find another solution with the |
@Dhaulagiri Updated this PR to use the run loop instead of concurrent tasks. I've tested it a few times and everything seems to be working as expected. Would you be able to pull it into a project and double check? |
@@ -50,6 +50,7 @@ | |||
"ember-disable-prototype-extensions": "^1.1.2", | |||
"ember-export-application-global": "^2.0.0", | |||
"ember-load-initializers": "^1.0.0", | |||
"ember-maybe-import-regenerator": "^0.1.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this only used for tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Was getting it for free with ember-concurrency
apparently. Shouldn't add to the library size as it's just a devDependency
but I can roll the tests back to nested andThen
's if that's preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, that sounds great to me. Just wanted to double check.
Worked great in our app 👏 |
Merged! Think we could cut another release? |
Released in 1.6.2 |
No description provided.