remove requirement for providing a message

[st-h]

fixes #259

I figured it would be reasonable to keep the message property required when preventDuplicates is enabled as that feature relies on the message string.

Please let me know or feel free to modify the added test, if you know of any better way to assert a thrown error than that:

assert.throws((() => {
  service.add({ });
}).message, 'Assertion Failed: The flash message cannot be empty when preventDuplicates is enabled.');

[sbatson5]

This looks great. Just one comment on the test and we should be good!

[sbatson5]

I think assert.throws is the right solution to test this. However, you seem to be getting a false positive. If you change this line to service.add({ message: 'foo' }) your test will still pass. I think this is due to the wrapped function.

I think you will want something like this:

  assert.throws(() => {
    service.add({ });
  },
  ({ message }) => {
    return message == 'Assertion Failed: The flash message cannot be empty when preventDuplicates is enabled.';
  },
    'Error is thrown'
  );

assert.throws can take 3 arguments. If you pass it only 2, the second is simply the assertion description, so it was not matching the error text here.

The second argument should be a function that accepts the error object and returns true or false. Give the above example a try and you should see it passes with no message and fails with one.

[st-h]

ah, thanks for catching that. Should all be fixed now :)

[sbatson5]

Minor nitpick, but rather than queue.0 could we do queue.firstObject? I feel it reads just a bit more clear

[st-h]

yup, done :)

[sbatson5]

Awesome!