add aria-label and others to flash message attrs #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dhaulagiri Think I could get a quick review here? |
sbatson5
force-pushed
the
add-accessibility-attrs-to-component
branch
from
dd7c272 to
4cbb58d
Compare
sbatson5
force-pushed
the
add-accessibility-attrs-to-component
branch
from
4cbb58d to
904a4e4
Compare
sbatson5
commented
Jun 6, 2018
| @@ -75,6 +75,7 @@ module.exports = function() { | |||
| }, | |||
| { | |||
| name: 'ember-beta', | |||
| allowedToFail: true, | |||
There was a problem hiding this comment.
Beta should be allowed to fail, imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Ran into this problem on a client project where we needed to add some accessibility fields to these components.