using url-parse in getBaseUrl #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitjes
requested changes
Nov 10, 2017
| @@ -2,12 +2,13 @@ | |||
|
|
|||
| var Promise = require('pouchdb-promise'); | |||
| var urlJoin = require('url-join'); | |||
| var parse = require('url-parse'); | |||
There was a problem hiding this comment.
Could you call the function urlParse for symmetry ?
| } else { // pouchdb post-6.0.0 | ||
| return db.name.replace(/\/[^\/]+\/?$/, ''); | ||
| return parse(db.__opts && db.__opts.prefix || db.name).origin; |
There was a problem hiding this comment.
You added a db.__opts && db.__opts.prefix case. What does it add compared to db.name ?
|
Note: This surely would fix #150. |
tlvince
added a commit
to tlvince/pouchdb-authentication
that referenced
this pull request
Nov 15, 2017
If [PouchDB.defaults][1] is used, its options are attached to `__.opts`.
In the case of `PouchDB.defaults({prefix: ''})`:
> `prefix` appends a prefix to the database name and can be helpful for
> URL-based or file-based LevelDOWN path names.
For example: `{prefix: 'https://example.com/', name: 'test'}` would
produce a DB "name" of `https://example.com/test`.
Before, prefix was not respected.
Closes pouchdb-community#158.
Connects pouchdb-community#160.
[1]: https://pouchdb.com/api.html#defaults
tlvince
added a commit
that referenced
this pull request
Nov 15, 2017
ptitjes
pushed a commit
to ptitjes/pouchdb-authentication
that referenced
this pull request
Nov 17, 2017
If [PouchDB.defaults][1] is used, its options are attached to `__.opts`.
In the case of `PouchDB.defaults({prefix: ''})`:
> `prefix` appends a prefix to the database name and can be helpful for
> URL-based or file-based LevelDOWN path names.
For example: `{prefix: 'https://example.com/', name: 'test'}` would
produce a DB "name" of `https://example.com/test`.
Before, prefix was not respected.
Closes pouchdb-community#158.
Connects pouchdb-community#160.
[1]: https://pouchdb.com/api.html#defaults
ptitjes
pushed a commit
to ptitjes/pouchdb-authentication
that referenced
this pull request
Nov 17, 2017
Reimplements pouchdb-community#160. Closes pouchdb-community#150. Closes pouchdb-community#160.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.