Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve range of camera transformation tests #283

Open
AstraLuma opened this issue May 25, 2019 · 1 comment
Open

Improve range of camera transformation tests #283

AstraLuma opened this issue May 25, 2019 · 1 comment
Labels
tests Related to tests. When applied to PRs is a note that tests are required before merge.

Comments

@AstraLuma
Copy link
Member

test_transfromation_roundtrip (#275) are currently limited to camera position of 1e15, unlike the usual 1e75 of most of our tests. This is to make sure that the generated frame actually has a size discernible to python floats. (that is, if the frame size is 2 and the camera position is 1e20, frame left will exactly equal frame right because 2 is below its precision).

Expert suggestion:

07:42:57 AstraLuma: You could generate one parameter as a multiple of the other using data() or composite() to generate a pair at once. Generate a single value and then the other as a st.floats(0.5, 2) multiple of that
07:43:01 (or some other suitable range)

@AstraLuma
Copy link
Member Author

Ok, 1e15 is more than enough for all of our known use cases at this time.

@pathunstrom pathunstrom added the tests Related to tests. When applied to PRs is a note that tests are required before merge. label Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to tests. When applied to PRs is a note that tests are required before merge.
Projects
None yet
Development

No branches or pull requests

2 participants